Files
9router/tests/unit/openai-to-claude.test.js
T
Hamsa_MandJoJo 315dcaa37a fix: strip empty Read pages argument in OpenAI-to-Claude translator (#1354)
Some OpenAI-compatible providers emit optional string tool parameters
as empty strings (e.g. pages: "") instead of omitting them. Claude
Code rejects pages: "" as invalid, breaking the Read tool for
non-PDF files routed through 9router.

Add sanitizeToolArguments() that parses tool-call arguments and
removes known optional empty-string fields before emitting
input_json_delta back to Claude format. Currently handles the
Read tool pages field specifically.

Includes regression test.

Fixes #1278

Co-authored-by: JoJo <noreply@github.com>
2026-05-23 09:27:13 +07:00

163 lines
5.0 KiB
JavaScript

/**
* Unit tests for open-sse/translator/request/openai-to-claude.js
*
* Tests cover:
* - openaiToClaudeRequest() - OpenAI to Claude request translation
* - Response format handling (json_schema, json_object)
*/
import { describe, it, expect } from "vitest";
import { openaiToClaudeRequest } from "../../open-sse/translator/request/openai-to-claude.js";
import { openaiToClaudeResponse } from "../../open-sse/translator/response/openai-to-claude.js";
describe("openaiToClaudeRequest", () => {
describe("response_format handling", () => {
it("should inject JSON schema instructions for json_schema type", () => {
const body = {
messages: [{ role: "user", content: "What is 2+2?" }],
response_format: {
type: "json_schema",
json_schema: {
name: "math_response",
schema: {
type: "object",
properties: {
answer: { type: "number" },
explanation: { type: "string" }
},
required: ["answer", "explanation"]
}
}
}
};
const result = openaiToClaudeRequest("claude-sonnet-4.5", body, false);
// Should have system array with instructions
expect(result.system).toBeDefined();
expect(Array.isArray(result.system)).toBe(true);
// Check that system prompt includes schema
const systemText = result.system
.filter(s => s.type === "text")
.map(s => s.text)
.join("\n");
expect(systemText).toContain("You must respond with valid JSON");
expect(systemText).toContain("\"answer\"");
expect(systemText).toContain("\"explanation\"");
expect(systemText).toContain("Respond ONLY with the JSON object");
});
it("should inject basic JSON instructions for json_object type", () => {
const body = {
messages: [{ role: "user", content: "Give me a JSON object" }],
response_format: {
type: "json_object"
}
};
const result = openaiToClaudeRequest("claude-sonnet-4.5", body, false);
// Should have system array with instructions
expect(result.system).toBeDefined();
expect(Array.isArray(result.system)).toBe(true);
const systemText = result.system
.filter(s => s.type === "text")
.map(s => s.text)
.join("\n");
expect(systemText).toContain("You must respond with valid JSON");
expect(systemText).toContain("Respond ONLY with a JSON object");
});
it("should not modify system prompt when response_format is missing", () => {
const body = {
messages: [{ role: "user", content: "Hello" }]
};
const result = openaiToClaudeRequest("claude-sonnet-4.5", body, false);
// Should have system but without JSON instructions
expect(result.system).toBeDefined();
const systemText = result.system
.filter(s => s.type === "text")
.map(s => s.text)
.join("\n");
// Should NOT contain JSON-specific instructions
expect(systemText).not.toContain("You must respond with valid JSON");
});
it("should preserve existing system messages when adding response_format", () => {
const body = {
messages: [
{ role: "system", content: "You are a helpful math tutor." },
{ role: "user", content: "What is 2+2?" }
],
response_format: {
type: "json_schema",
json_schema: {
schema: {
type: "object",
properties: {
result: { type: "number" }
}
}
}
}
};
const result = openaiToClaudeRequest("claude-sonnet-4.5", body, false);
// Should preserve original system message
const systemText = result.system
.filter(s => s.type === "text")
.map(s => s.text)
.join("\n");
expect(systemText).toContain("You are a helpful math tutor");
expect(systemText).toContain("You must respond with valid JSON");
});
});
});
describe("openaiToClaudeResponse", () => {
it("omits empty Read pages tool argument before emitting Claude input deltas", () => {
const state = { toolCalls: new Map() };
const chunk = {
id: "chatcmpl-test",
model: "gpt-test",
choices: [{
delta: {
tool_calls: [{
index: 0,
id: "call_read",
function: {
name: "Read",
arguments: JSON.stringify({
file_path: "/tmp/example.txt",
offset: 0,
limit: 120,
pages: ""
})
}
}]
}
}]
};
const result = openaiToClaudeResponse(chunk, state);
const inputDelta = result.find(event => event.delta?.type === "input_json_delta");
expect(inputDelta).toBeDefined();
expect(JSON.parse(inputDelta.delta.partial_json)).toEqual({
file_path: "/tmp/example.txt",
offset: 0,
limit: 120
});
});
});