Optimized code

This commit is contained in:
2023-10-29 09:58:05 +07:00
parent d44eb6ff11
commit 7e7b9b29d5
+38 -28
View File
@@ -15,6 +15,7 @@ import { useFetch } from '../../hooks/useFetch';
// Styled // Styled
import Spinner from '../../commons/styles/Spinner'; import Spinner from '../../commons/styles/Spinner';
import { useEffect, useState } from 'react';
type TUserModal = { user: TUser }; type TUserModal = { user: TUser };
@@ -54,38 +55,47 @@ const UserRow = ({ user }: TUserModal) => {
const UserTable = () => { const UserTable = () => {
const { data, isPending, errorMsg } = useFetch('users'); const { data, isPending, errorMsg } = useFetch('users');
let users: TUser[] = []; const [users, setUsers] = useState<TUser[]>([]);
if (data) users = data; useEffect(() => {
if (data) {
setUsers(data);
}
if (isPending) return <Spinner />; if (errorMsg) {
console.error(errorMsg);
}
}, [data, errorMsg]);
if (errorMsg) console.error(errorMsg); return (
<>
{isPending && <Spinner />}
{users.length ? (
<Direction>
<StyledOperationTable>
<p>Sort / Search table</p>
</StyledOperationTable>
return users.length ? ( <Menus>
<Direction> <Table columns="10% 30% 20% 20% 10% 5%">
<StyledOperationTable> <Table.Header>
<p>Sort / Search table</p> <div>Id</div>
</StyledOperationTable> <div>Name</div>
<div>Identified Code</div>
<Menus> <div>Phone</div>
<Table columns="10% 30% 20% 20% 10% 5%"> <div>Room</div>
<Table.Header> </Table.Header>
<div>Id</div> <Table.Body<TUser>
<div>Name</div> data={users}
<div>Identified Code</div> render={(user: TUser) => <UserRow user={user} key={user.id} />}
<div>Phone</div> />
<div>Room</div> </Table>
</Table.Header> </Menus>
<Table.Body<TUser> </Direction>
data={users} ) : (
render={(user: TUser) => <UserRow user={user} key={user.id} />} <Message>No data to show here!</Message>
/> )}
</Table> </>
</Menus>
</Direction>
) : (
<Message>No data to show here!</Message>
); );
}; };