From 18e1d8b70105a7be5514e8045c7adecac66bb34e Mon Sep 17 00:00:00 2001
From: Loi Phan <phanhuuloi15@gmail.com>
Date: Fri, 29 Sep 2023 16:53:22 +0700
Subject: [PATCH] Improve register method

---
 typescript-practice/.vscode/launch.json       | 19 +++++
 .../src/ts/views/commonView.ts                | 70 ++++++++++---------
 .../src/ts/views/registerView.ts              |  4 ++
 3 files changed, 59 insertions(+), 34 deletions(-)
 create mode 100644 typescript-practice/.vscode/launch.json

diff --git a/typescript-practice/.vscode/launch.json b/typescript-practice/.vscode/launch.json
new file mode 100644
index 0000000..ac819dd
--- /dev/null
+++ b/typescript-practice/.vscode/launch.json
@@ -0,0 +1,19 @@
+{
+  // Use IntelliSense to learn about possible attributes.
+  // Hover to view descriptions of existing attributes.
+  // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+  "version": "0.2.0",
+  "configurations": [
+    {
+      "type": "msedge",
+      "request": "launch",
+      "name": "Launch Edge against localhost",
+      "url": "http://localhost:1234",
+      "webRoot": "${workspaceFolder}",
+      "breakOnLoad": true,
+      "sourceMapPathOverrides": {
+        "/__parcel_source_root/*": "${webRoot}/*"
+      }
+    }
+  ]
+}
diff --git a/typescript-practice/src/ts/views/commonView.ts b/typescript-practice/src/ts/views/commonView.ts
index 40a350c..4791241 100644
--- a/typescript-practice/src/ts/views/commonView.ts
+++ b/typescript-practice/src/ts/views/commonView.ts
@@ -1,43 +1,22 @@
 import { MarkIcon, TypeToast } from '../constants/config';
 
 export default class CommonView {
-  public rootElement: HTMLBodyElement | null;
+  public toastDialog: HTMLDialogElement | null = null;
 
-  public toastDialog: HTMLDialogElement | null;
+  public toastIcon: HTMLBodyElement | null = null;
 
-  public toast: HTMLBodyElement | null;
+  public toastBtn: HTMLBodyElement | null = null;
 
-  public toastIcon: HTMLBodyElement | null;
+  public toastTitle: HTMLBodyElement | null = null;
 
-  public toastBtn: HTMLBodyElement | null;
+  public toastContent: HTMLBodyElement | null = null;
 
-  public toastTitle: HTMLBodyElement | null;
-
-  public toastContent: HTMLBodyElement | null;
-
-  public spinner: HTMLBodyElement | null;
+  public spinner: HTMLBodyElement | null = null;
 
   constructor() {
-    this.rootElement = document.querySelector('body');
     this.toastDialog = document.querySelector('.dialog');
-    this.toast = document.querySelector('.toast');
-
-    this.toastIcon = this.toast ? this.toast.querySelector('.mark') : null;
-    this.toastBtn = this.toast
-      ? this.toast.querySelector('.toast__redirect-btn')
-      : null;
-    this.toastTitle = this.toast
-      ? this.toast.querySelector('.toast__title')
-      : null;
-    this.toastContent = this.toast
-      ? this.toast.querySelector('.toast__message')
-      : null;
 
     this.spinner = null;
-
-    // this.initToast();
-    // this.initLoader();
-    // this.handleEventToast();
   }
 
   /**
@@ -55,8 +34,28 @@ export default class CommonView {
       </dialog>
     `;
 
-    if (this.rootElement)
-      this.rootElement.insertAdjacentHTML('afterbegin', markup);
+    const body = document.querySelector('body');
+
+    if (body) body.insertAdjacentHTML('afterbegin', markup);
+
+    this.initToastEl();
+  }
+
+  initToastEl() {
+    this.toastDialog = document.querySelector('.dialog');
+
+    this.toastIcon = this.toastDialog
+      ? this.toastDialog.querySelector('.mark')
+      : null;
+    this.toastBtn = this.toastDialog
+      ? this.toastDialog.querySelector('.toast__redirect-btn')
+      : null;
+    this.toastTitle = this.toastDialog
+      ? this.toastDialog.querySelector('.toast__title')
+      : null;
+    this.toastContent = this.toastDialog
+      ? this.toastDialog.querySelector('.toast__message')
+      : null;
   }
 
   /**
@@ -81,7 +80,10 @@ export default class CommonView {
   ): void {
     // Remove old typeToast class if haved
     Object.keys(TypeToast).forEach((key) => {
-      CommonView.removeClassElement(TypeToast[key as TypeToast], this.toast);
+      CommonView.removeClassElement(
+        TypeToast[key as TypeToast],
+        this.toastDialog as HTMLBodyElement | null,
+      );
     });
 
     // Remove old icon toast if haved
@@ -91,13 +93,13 @@ export default class CommonView {
 
     // Init content toast
     if (
-      this.toast &&
+      this.toastDialog &&
       this.toastIcon &&
       this.toastTitle &&
       this.toastContent &&
       this.toastBtn
     ) {
-      this.toast.classList.add(
+      this.toastDialog.classList.add(
         typeToast === TypeToast.success ? TypeToast.success : TypeToast.error,
       );
       this.toastIcon.classList.add(
@@ -149,8 +151,8 @@ export default class CommonView {
   initLoader() {
     const markup = `<div class="loader hidden"></div>`;
 
-    if (this.rootElement)
-      this.rootElement.insertAdjacentHTML('afterbegin', markup);
+    const body = document.querySelector('body');
+    if (body) body.insertAdjacentHTML('afterbegin', markup);
 
     // Init element
     this.spinner = document.querySelector('.loader');
diff --git a/typescript-practice/src/ts/views/registerView.ts b/typescript-practice/src/ts/views/registerView.ts
index 1cc0665..c02e336 100644
--- a/typescript-practice/src/ts/views/registerView.ts
+++ b/typescript-practice/src/ts/views/registerView.ts
@@ -14,6 +14,10 @@ export default class RegisterView extends AuthenticationView {
   constructor() {
     super();
 
+    this.initToast();
+    this.initLoader();
+    this.handleEventToast();
+
     this.toastBtn = document.querySelector('.toast__redirect-btn');
   }