From e43fb32837dc3c324fe3c8c2ac92387aa6eaa744 Mon Sep 17 00:00:00 2001 From: Loi Phan Date: Tue, 3 Oct 2023 21:29:16 +0700 Subject: [PATCH] Update naming convention --- typescript-practice/src/ts/global/types.ts | 2 +- typescript-practice/src/ts/helpers/evDataTrigger.ts | 8 ++++---- typescript-practice/src/ts/views/home/budgetView.ts | 4 ++-- typescript-practice/src/ts/views/home/categoryView.ts | 4 ++-- typescript-practice/src/ts/views/home/homeView.ts | 6 +++--- typescript-practice/src/ts/views/home/summaryTabView.ts | 4 ++-- .../src/ts/views/home/transactionTabView.ts | 4 ++-- typescript-practice/src/ts/views/home/transactionView.ts | 6 +++--- typescript-practice/src/ts/views/home/walletView.ts | 4 ++-- 9 files changed, 21 insertions(+), 21 deletions(-) diff --git a/typescript-practice/src/ts/global/types.ts b/typescript-practice/src/ts/global/types.ts index e4ef3c3..ae9860c 100644 --- a/typescript-practice/src/ts/global/types.ts +++ b/typescript-practice/src/ts/global/types.ts @@ -35,7 +35,7 @@ export class CustomError extends Error { } } -export interface Data { +export interface DataTransfer { wallet?: Wallet; listTransactions?: Transaction[]; listCategories?: Category[]; diff --git a/typescript-practice/src/ts/helpers/evDataTrigger.ts b/typescript-practice/src/ts/helpers/evDataTrigger.ts index 00178f7..cf85fa9 100644 --- a/typescript-practice/src/ts/helpers/evDataTrigger.ts +++ b/typescript-practice/src/ts/helpers/evDataTrigger.ts @@ -1,9 +1,9 @@ -import { Data } from 'global/types'; +import { DataTransfer } from 'global/types'; type TSignal = { [key: string]: { name: string; - handler: (value: Data) => void; + handler: (value: DataTransfer) => void; }; }; @@ -20,7 +20,7 @@ export default class EventDataTrigger { return this._instance || (this._instance = new this()); } - onSendSignal(fromClass: string, value: Data) { + onSendSignal(fromClass: string, value: DataTransfer) { Object.keys(this.signal).forEach((key) => { const item = this.signal[key as keyof TSignal]; @@ -39,7 +39,7 @@ export default class EventDataTrigger { create( className: string, - handler: ((value: Data) => void) | null = null, + handler: ((value: DataTransfer) => void) | null = null, ): void { if (handler) this.signal[className] = { name: className, handler }; } diff --git a/typescript-practice/src/ts/views/home/budgetView.ts b/typescript-practice/src/ts/views/home/budgetView.ts index 4bcc37f..b02f9e0 100644 --- a/typescript-practice/src/ts/views/home/budgetView.ts +++ b/typescript-practice/src/ts/views/home/budgetView.ts @@ -7,7 +7,7 @@ import { DEFAULT_CATEGORY } from 'constants/config'; import { TOAST } from 'constants/messages'; import { IBudgetViewFunc, - Data, + DataTransfer, Nullable, PromiseVoid, TError, @@ -70,7 +70,7 @@ export default class BudgetView { this.evDataTrigger!.onSendSignal('budgetView', data); } - updateData(data: Data) { + updateData(data: DataTransfer) { if (data.wallet) this.wallet = data.wallet; if (data.user) this.user = data.user; diff --git a/typescript-practice/src/ts/views/home/categoryView.ts b/typescript-practice/src/ts/views/home/categoryView.ts index 1124694..36a91b4 100644 --- a/typescript-practice/src/ts/views/home/categoryView.ts +++ b/typescript-practice/src/ts/views/home/categoryView.ts @@ -1,7 +1,7 @@ import EventDataTrigger from 'helpers/evDataTrigger'; import { REMOVE_CATEGORY } from '../../constants/config'; import Category from 'models/category'; -import { Data, Nullable, PromiseOrNull } from 'global/types'; +import { DataTransfer, Nullable, PromiseOrNull } from 'global/types'; export default class CategoryView { categoryDialog: Nullable = null; @@ -40,7 +40,7 @@ export default class CategoryView { } sendData() { - const data: Data = { listCategories: this.listCategory! }; + const data: DataTransfer = { listCategories: this.listCategory! }; this.evDataTrigger!.onSendSignal('categoryView', data); } diff --git a/typescript-practice/src/ts/views/home/homeView.ts b/typescript-practice/src/ts/views/home/homeView.ts index 60d15b0..2efce01 100644 --- a/typescript-practice/src/ts/views/home/homeView.ts +++ b/typescript-practice/src/ts/views/home/homeView.ts @@ -8,7 +8,7 @@ import EventDataTrigger from 'helpers/evDataTrigger'; import Transaction from 'models/transaction'; import User from 'models/user'; import { - Data, + DataTransfer, IBudgetViewFunc, IHomeFunc, ITransactionViewFunc, @@ -236,7 +236,7 @@ export default class HomeView extends CommonView { } sendData() { - const data: Data = { + const data: DataTransfer = { wallet: this.wallet!, listTransactions: this.listTransactions!, user: this.user!, @@ -245,7 +245,7 @@ export default class HomeView extends CommonView { this.evDataTrigger!.onSendSignal('homeView', data); } - updateData(data: Data) { + updateData(data: DataTransfer) { if (data.wallet) this.wallet = data.wallet; if (data.user) this.user = data.user; diff --git a/typescript-practice/src/ts/views/home/summaryTabView.ts b/typescript-practice/src/ts/views/home/summaryTabView.ts index eae2560..094612d 100644 --- a/typescript-practice/src/ts/views/home/summaryTabView.ts +++ b/typescript-practice/src/ts/views/home/summaryTabView.ts @@ -1,6 +1,6 @@ import EventDataTrigger from 'helpers/evDataTrigger'; import { formatNumber } from '../../helpers/data'; -import { Data, Nullable } from 'global/types'; +import { DataTransfer, Nullable } from 'global/types'; import Wallet from 'models/wallet'; import Transaction from 'models/transaction'; import Category from 'models/category'; @@ -22,7 +22,7 @@ export default class SummaryTabView { this.evDataTrigger!.create('summaryTabView', this.updateData.bind(this)); } - updateData(data: Data) { + updateData(data: DataTransfer) { if (data.wallet) this.wallet = data.wallet; if (data.listTransactions) this.listTransactions = data.listTransactions; diff --git a/typescript-practice/src/ts/views/home/transactionTabView.ts b/typescript-practice/src/ts/views/home/transactionTabView.ts index c365ea5..38573e9 100644 --- a/typescript-practice/src/ts/views/home/transactionTabView.ts +++ b/typescript-practice/src/ts/views/home/transactionTabView.ts @@ -6,7 +6,7 @@ import { } from '../../helpers/data'; import { formatNumber } from '../../helpers/data'; import TransactionView from './transactionView'; -import { Data, Nullable } from 'global/types'; +import { DataTransfer, Nullable } from 'global/types'; import Wallet from 'models/wallet'; import Transaction from 'models/transaction'; import Category from 'models/category'; @@ -41,7 +41,7 @@ export default class TransactionTabView { ); } - updateData(data: Data) { + updateData(data: DataTransfer) { if (data.wallet) this.wallet = data.wallet; if (data.listTransactions) this.listTransactions = data.listTransactions; diff --git a/typescript-practice/src/ts/views/home/transactionView.ts b/typescript-practice/src/ts/views/home/transactionView.ts index 4b55389..ce755eb 100644 --- a/typescript-practice/src/ts/views/home/transactionView.ts +++ b/typescript-practice/src/ts/views/home/transactionView.ts @@ -3,7 +3,7 @@ import defaultCategoryIcon from '../../../assets/images/question-icon.svg'; import CategoryView from './categoryView'; import EventDataTrigger from 'helpers/evDataTrigger'; import { - Data, + DataTransfer, ITransactionViewFunc, Nullable, PromiseVoid, @@ -80,7 +80,7 @@ export default class TransactionView { } sendData() { - const data: Data = { + const data: DataTransfer = { wallet: this.wallet!, listTransactions: this.listTransactions!, }; @@ -88,7 +88,7 @@ export default class TransactionView { this.evDataTrigger!.onSendSignal('transactionView', data); } - updateData(data: Data) { + updateData(data: DataTransfer) { if (data.wallet) this.wallet = data.wallet; if (data.listTransactions) this.listTransactions = data.listTransactions; diff --git a/typescript-practice/src/ts/views/home/walletView.ts b/typescript-practice/src/ts/views/home/walletView.ts index 8954740..fb2f5ee 100644 --- a/typescript-practice/src/ts/views/home/walletView.ts +++ b/typescript-practice/src/ts/views/home/walletView.ts @@ -3,7 +3,7 @@ import Wallet from '../../models/wallet'; import { renderRequiredText } from '../../helpers/validatorForm'; import EventDataTrigger from 'helpers/evDataTrigger'; import { - Data, + DataTransfer, IWalletViewFunc, Nullable, PromiseVoid, @@ -73,7 +73,7 @@ export default class WalletView { this.evDataTrigger!.onSendSignal('walletView', data); } - updateData(data: Data) { + updateData(data: DataTransfer) { if (data.wallet) this.wallet = data.wallet; if (data.user) this.user = data.user;